切换菜单栏形式前停止旧动画 - #21
Merged
TNT-Likely merged 1 commit intoJun 4, 2026
Merged
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — stops ticker animations before swapping views to prevent stale CVDisplayLink callbacks from firing against a replaced view.
- Add
invalidateAnimation()toMenuBarTickerViewprotocol — new protocol requirement that all conforming types implement. - Implement in
TickerViewandCarouselTickerView— delegates to existingstopAnimation(), which stops and nils theCVDisplayLink. - No-op in
CompactTickerViewandMinimalTickerView— these static views have no animations to invalidate. - Call from
StatusItemController.swapTickerView(to:)— callsinvalidateAnimation()before constructing the new view, ensuring the old display link is stopped before it can fire against the old (soon-to-be-released) view.
DeepSeek Flash | 𝕏
This was referenced Jun 4, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

这个 PR 优化菜单栏展示形式切换时的动画状态清理。
改动内容:
验证: